Re: [Qemu-devel] [PATCH for-1.2 v2] target-xtensa: return ENOSYS for unimplemented simcalls

[Blue Swirl]

Thanks, applied.

On Wed, Aug 22, 2012 at 6:03 PM, Max Filippov <address@hidden> wrote:
> This prevents guest from proceeding with uninitialised garbage returned
> from unimplemented simcalls.
>
> Signed-off-by: Max Filippov <address@hidden>
> ---
>  target-xtensa/xtensa-semi.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/target-xtensa/xtensa-semi.c b/target-xtensa/xtensa-semi.c
> index 1c8a19e..6d001c2 100644
> --- a/target-xtensa/xtensa-semi.c
> +++ b/target-xtensa/xtensa-semi.c
> @@ -218,6 +218,8 @@ void HELPER(simcall)(CPUXtensaState *env)
>
>      default:
>          qemu_log("%s(%d): not implemented\n", __func__, regs[2]);
> +        regs[2] = -1;
> +        regs[3] = ENOSYS;
>          break;
>      }
>  }
> --
> 1.7.7.6
>
>