[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers
|
From: |
Igor Mammedov |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers |
|
Date: |
Thu, 30 Aug 2012 10:17:10 +0200 |
On Thu, 30 Aug 2012 09:41:55 +0200
Paolo Bonzini <address@hidden> wrote:
> Il 30/08/2012 08:49, Igor Mammedov ha scritto:
> >>> > > +static void qemu_system_powerdown(void)
> > this is a bad naming that conflicts with global var qemu_system_powerdown,
> > so
> > bisectability of series is still broken.
> > perhaps qemu_do_system_powerdown() would be better for function name,
> > although it doesn't match common name pattern used for this kind of
> > functions.
> >
>
> Just inline the function in this patch, and uninline it later.
Thanks, fixed in https://github.com/imammedo/qemu/tree/cpu_as_device.WIP
>
> Paolo
>
--
Regards,
Igor
- [Qemu-devel] [PATCH 0/5 v2] convert system_powerdown command to notifiers, Igor Mammedov, 2012/08/29
- [Qemu-devel] [PATCH 2/5] acpi: use notifier for signaling guest system_powerdown command, Igor Mammedov, 2012/08/29
- [Qemu-devel] [PATCH 3/5] target-arm: use notifier for signaling guest system_powerdown command, Igor Mammedov, 2012/08/29
- [Qemu-devel] [PATCH 4/5] target-sparc: use notifier for signaling guest system_powerdown command, Igor Mammedov, 2012/08/29
- [Qemu-devel] [PATCH 5/5] cleanup unused qemu_system_powerdown, Igor Mammedov, 2012/08/29
- [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers, Igor Mammedov, 2012/08/29