Re: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning caused by illegal type cast

[Hannes Reinecke]

On 08/24/2012 10:16 AM, Paolo Bonzini wrote:
> Il 24/08/2012 10:31, Hannes Reinecke ha scritto:
>>
>>> Type casts from pointer to integer values must use uintptr_t
>>> instead of unsigned long. Otherwise the compiler complains on
>>> hosts with sizeof(pointer) != sizeof(long).
>>>
>>> The patch also replace magic number 32 by sizeof(info.serial_number)
>>> which has the same value but is better for code reviews.
>>>
>>> Signed-off-by: Stefan Weil <address@hidden>
>>
>> Sigh. I never seem to get the hang of typecasting.
>>
>> Acked-by: Hannes Reinecke <address@hidden>
> 
> Nope, this needs to be fixed using the same scheme that you used for SAS
> addresses.  Quick before Anthony notices and disables MEGASAS. :)
> 
Ok, done.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                   zSeries & Storage
address@hidden                        +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)