Re: [Qemu-devel] [PATCH v4] linux-user: fix emulation of getdents

[Peter Maydell]

On 20 August 2012 23:13, Dmitry V. Levin <address@hidden> wrote:
> In case when TARGET_ABI_BITS == 32 && HOST_LONG_BITS == 64, the last
> byte of the target dirent structure (aka d_type byte) was never copied
> from the host dirent structure, thus breaking everything that relies
> on valid d_type value, e.g. glob(3).
>
> Signed-off-by: Dmitry V. Levin <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

(though not tested, since the 32 bit target I care about (ARM) uses
getdents64 rather than getdents.)

-- PMM