Re: [Qemu-devel] [PATCH] Add a '-r' option to qmp-shell to print out raw JSON replies

[Daniel P. Berrange]

On Mon, Aug 20, 2012 at 03:22:35PM -0300, Luiz Capitulino wrote:
> On Mon, 20 Aug 2012 15:02:23 +0100
> "Daniel P. Berrange" <address@hidden> wrote:
> 
> > From: "Daniel P. Berrange" <address@hidden>
> > 
> > By default, the JSON reply is parsed and the corresponding python
> > object printed on the console. When developing JSON client apps
> > for QEMU though, it is handy to see the raw JSON document instead.
> > Add a '-r' option that will cause the raw JSON to be printed,
> > instead of the parsed object. eg
> 
> Looks good, but depends on the previous patch (which is being discussed).
> 
> Btw, I wonder if we should make this the default, or add -v (instead of
> -r) which would allow for extra verbosity by printing both: the reply
> as read by qmp-shell and the parsed.

I dunno, I feel the current default is reasonable and printing both
would be a bit too verbose for commands with larger output.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|