qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] pl190: fix read of VECTADDR


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v3] pl190: fix read of VECTADDR
Date: Mon, 20 Aug 2012 19:11:27 +0100

On 20 August 2012 18:59, Brendan Fennell <address@hidden> wrote:
> Signed-off-by: Brendan Fennell <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

The () inside the [] aren't actually necessary, but I'm just
going to fix those as I take this patch into the arm-devs
queue, I think. I've also expanded the commit message a little:

=====
Reading VECTADDR was causing us to set the current priority to
the wrong value, the most obvious effect of which was that we
would return the vector for the wrong interrupt as the result
of the read.
=====

What guest did you see this problem with? Since the QEMU 1.2
release is now less than 2 weeks away, and this bug has been
present since the versatilepb platform was added 6 years ago,
I'm reluctant to squeeze it into this release unless it's
going to be hit by a lot of people. (1.3 is only 3 months
later so it's not a huge deal for a minor fix to miss 1.2.)

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]