[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] cleanup error.h, included qapi-types.h area
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] cleanup error.h, included qapi-types.h aready has stdbool.h |
Date: |
Mon, 20 Aug 2012 12:28:05 -0300 |
On Mon, 20 Aug 2012 01:39:38 +0200
Igor Mammedov <address@hidden> wrote:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> error.h | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/error.h b/error.h
> index 96fc203..643a372 100644
> --- a/error.h
> +++ b/error.h
> @@ -14,7 +14,6 @@
>
> #include "compiler.h"
> #include "qapi-types.h"
> -#include <stdbool.h>
Hmm, not good. qapi-types.h includes <stdbool.h> for internal matters, files
including qapi-types.h shouldn't rely on this (as they can break if qapi-types.h
is changed not to include <stdbool.h>).
You can keep this code as it is.
>
> /**
> * A class representing internal errors within QEMU. An error has a
> ErrorClass
- [Qemu-devel] [PATCH 1/5] move qemu_irq typedef out of cpu-common.h, (continued)
[Qemu-devel] [PATCH 3/5] qapi-types.h doesn't really need to include qemu-common.h, Igor Mammedov, 2012/08/19
[Qemu-devel] [PATCH 2/5] qdev: split up header so it can be used in cpu.h, Igor Mammedov, 2012/08/19
[Qemu-devel] [PATCH 4/5] cleanup error.h, included qapi-types.h aready has stdbool.h, Igor Mammedov, 2012/08/19
- Re: [Qemu-devel] [PATCH 4/5] cleanup error.h, included qapi-types.h aready has stdbool.h,
Luiz Capitulino <=
[Qemu-devel] [PATCH 5/5] make CPU a child of DeviceState, Igor Mammedov, 2012/08/19
Re: [Qemu-devel] [PATCH 0/5 v2] cpu: make a child of DeviceState, Stefan Weil, 2012/08/20