[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races be
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort |
Date: |
Mon, 20 Aug 2012 09:22:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
Il 19/08/2012 21:22, Stefan Priebe - Profihost AG ha scritto:
>
>> No problem, my fault---I'm just back and I haven't really started again
>> all my stuff, so the patch was not tested.
>>
>> This should fix it, though.
>
> Booting works fine now. But the VM starts to hang after trying to unmap
> large regions. No segfault or so just not reacting anymore.
This is expected; unfortunately cancellation right now is a synchronous
operation in the block layer. SCSI is the first big user of
cancellation, and it would indeed benefit from asynchronous cancellation.
Without these three patches, you risk corruption in case the following
happens:
qemu target
-----------------------------------
send unmap -------->
cancel unmap ------>
send write -------->
<---------------- complete write
<unmap just written sector>
<---------------- complete unmap
<---------------- cancellation done (unmap complete)
Paolo
- [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort, Paolo Bonzini, 2012/08/18
- [Qemu-devel] [PATCH 1/3] iscsi: move iscsi_schedule_bh and iscsi_readv_writev_bh_cb, Paolo Bonzini, 2012/08/18
- [Qemu-devel] [PATCH 2/3] iscsi: simplify iscsi_schedule_bh, Paolo Bonzini, 2012/08/18
- [Qemu-devel] [PATCH 3/3] iscsi: fix races between task completion and abort, Paolo Bonzini, 2012/08/18
- Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort, Stefan Priebe, 2012/08/19
- Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort, Paolo Bonzini, 2012/08/19
- Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort, Stefan Priebe - Profihost AG, 2012/08/19
- Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort, Stefan Priebe - Profihost AG, 2012/08/20
- Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort, Paolo Bonzini, 2012/08/20
- Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort, Stefan Priebe - Profihost AG, 2012/08/20
- Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort, ronnie sahlberg, 2012/08/20
- Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort, Stefan Priebe - Profihost AG, 2012/08/21
- Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort, Paolo Bonzini, 2012/08/21