[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] pl190: fix read of VECTADDR
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH v2] pl190: fix read of VECTADDR |
Date: |
Sun, 19 Aug 2012 13:02:34 +0000 |
On Sun, Aug 19, 2012 at 10:59 AM, Brendan Fennell <address@hidden> wrote:
>
> Signed-off-by: Brendan Fennell <address@hidden>
> ---
> hw/pl190.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/hw/pl190.c b/hw/pl190.c
> index cb50afb..eddb531 100644
> --- a/hw/pl190.c
> +++ b/hw/pl190.c
> @@ -120,7 +120,8 @@ static uint64_t pl190_read(void *opaque,
> target_phys_addr_t offset,
> current priority level to that of the current interrupt. */
> for (i = 0; i < s->priority; i++)
> {
> - if ((s->level | s->soft_level) & s->prio_mask[i])
> + /* Ensure that 'i' is current highest priority interrupt on exit
> */
> + if ((s->level | s->soft_level) & s->prio_mask[i+1])
Missing braces and spaces around '+', please read CODING_STYLE.
> break;
> }
> /* Reading this value with no pending interrupts is undefined.
> --
> 1.7.2.5
>
>