Re: [Qemu-devel] [PATCH] block: handle filenames with colons better

[Michael Tokarev]

On 16.08.2012 18:58, Iustin Pop wrote:
> Commit 947995c (block: protect path_has_protocol from filenames with
> colons) introduced a way to handle filenames with colons based on
> whether the path contains a slash or not. IMHO this is not optimal,
> since we shouldn't rely on the contents of the path but rather on
> whether the given path exists as a file or not.
> 
> As such, this patch tries to handle both files with and without
> slashes by falling back to opening them as files if no drivers
> supporting the protocol has been identified.

I for one dislike this idea entirely: I think there should be a
way to stop qemu from trying to open something as a file.  It
opens a security hole after all, "what if" such a file will actually
exist?

If I can vote, I'm voting against this with both hands.

Thanks,

/mjt