[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/6] trace/simple: Replace asprintf by g_strdup_prin
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 6/6] trace/simple: Replace asprintf by g_strdup_printf |
Date: |
Tue, 14 Aug 2012 13:56:28 +0100 |
From: Stefan Weil <address@hidden>
asprintf is not available for all hosts. g_strdup_printf is
more portable and simplifies the code because if does not
need error handling.
The static variable does not need an explicit assignment to be NULL.
Cc: Stefan Hajnoczi <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
trace/simple.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/trace/simple.c b/trace/simple.c
index 8e175ec..d83681b 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -55,7 +55,7 @@ static unsigned int trace_idx;
static unsigned int writeout_idx;
static uint64_t dropped_events;
static FILE *trace_fp;
-static char *trace_file_name = NULL;
+static char *trace_file_name;
/* * Trace buffer entry */
typedef struct {
@@ -329,18 +329,12 @@ bool st_set_trace_file(const char *file)
{
st_set_trace_file_enabled(false);
- free(trace_file_name);
+ g_free(trace_file_name);
if (!file) {
- if (asprintf(&trace_file_name, CONFIG_TRACE_FILE, getpid()) < 0) {
- trace_file_name = NULL;
- return false;
- }
+ trace_file_name = g_strdup_printf(CONFIG_TRACE_FILE, getpid());
} else {
- if (asprintf(&trace_file_name, "%s", file) < 0) {
- trace_file_name = NULL;
- return false;
- }
+ trace_file_name = g_strdup_printf("%s", file);
}
st_set_trace_file_enabled(true);
--
1.7.10.4
- [Qemu-devel] [PULL 0/6 1.2] Tracing patches for QEMU 1.2, Stefan Hajnoczi, 2012/08/14
- [Qemu-devel] [PATCH 1/6] trace: rename TraceRecordHeader to TraceLogHeader, Stefan Hajnoczi, 2012/08/14
- [Qemu-devel] [PATCH 2/6] trace: remove unnecessary write_to_buffer() typecasting, Stefan Hajnoczi, 2012/08/14
- [Qemu-devel] [PATCH 6/6] trace/simple: Replace asprintf by g_strdup_printf,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 3/6] trace: drop unused TraceBufferRecord->next_tbuf_idx field, Stefan Hajnoczi, 2012/08/14
- [Qemu-devel] [PATCH 4/6] trace: avoid pointer aliasing in trace_record_finish(), Stefan Hajnoczi, 2012/08/14
- [Qemu-devel] [PATCH 5/6] trace/simple: Fix compiler warning for 32 bit hosts, Stefan Hajnoczi, 2012/08/14
- Re: [Qemu-devel] [PULL 0/6 1.2] Tracing patches for QEMU 1.2, Anthony Liguori, 2012/08/14