|
From: | Igor Mammedov |
Subject: | Re: [Qemu-devel] [RFC 03/15] kvm: set vcpu_id to APIC ID instead of CPU index |
Date: | Mon, 13 Aug 2012 21:16:52 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 08/07/2012 09:56 PM, Eduardo Habkost wrote:
The CPU ID in KVM is supposed to be the APIC ID, so change the KVM_CREATE_VCPU call to match it. It didn't break anything yet because today the APIC ID is assumed to be == the CPU index, but this won't be true in the future.
What it would break if APIC ID != CPU index ?
Signed-off-by: Eduardo Habkost <address@hidden> --- kvm-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kvm-all.c b/kvm-all.c index 2148b20..38de992 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -213,7 +213,7 @@ int kvm_init_vcpu(CPUArchState *env) DPRINTF("kvm_init_vcpu\n"); - ret = kvm_vm_ioctl(s, KVM_CREATE_VCPU, env->cpu_index); + ret = kvm_vm_ioctl(s, KVM_CREATE_VCPU, env->cpuid_apic_id); if (ret < 0) { DPRINTF("kvm_create_vcpu failed\n"); goto err;
-- Regards, Igor
[Prev in Thread] | Current Thread | [Next in Thread] |