[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 06/20] target-i386: xlevel should be more than 0x8
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [RFC 06/20] target-i386: xlevel should be more than 0x80000000, move fixup into setter |
Date: |
Fri, 10 Aug 2012 11:44:18 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Aug 10, 2012 at 01:22:22PM +0200, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
> ---
> target-i386/cpu.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 783c6f4..a47cc12 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -745,8 +745,17 @@ static void x86_cpuid_set_xlevel(Object *obj, Visitor
> *v, void *opaque,
> const char *name, Error **errp)
> {
> X86CPU *cpu = X86_CPU(obj);
> + uint32_t value;
>
> - visit_type_uint32(v, &cpu->env.cpuid_xlevel, name, errp);
> + visit_type_uint32(v, &value, name, errp);
> + if (error_is_set(errp)) {
> + return;
> + }
> +
> + if (value < 0x80000000) {
> + value += 0x80000000;
> + }
> + cpu->env.cpuid_xlevel = value;
> }
>
> static char *x86_cpuid_get_vendor(Object *obj, Error **errp)
> @@ -981,9 +990,6 @@ static int cpu_x86_find_by_name(X86CPU *cpu, x86_def_t
> *x86_cpu_def,
> fprintf(stderr, "bad numerical value %s\n", val);
> goto error;
> }
> - if (numvalue < 0x80000000) {
> - numvalue += 0x80000000;
> - }
> x86_cpu_def->xlevel = numvalue;
> } else if (!strcmp(featurestr, "vendor")) {
> if (strlen(val) != 12) {
> --
> 1.7.11.2
>
--
Eduardo
- [Qemu-devel] [RFC 01/20] target-i386: return Error from cpu_x86_find_by_name(), (continued)
- [Qemu-devel] [RFC 01/20] target-i386: return Error from cpu_x86_find_by_name(), Igor Mammedov, 2012/08/10
- [Qemu-devel] [RFC 02/20] target-i386: cpu_x86_register(): report error from property setter, Igor Mammedov, 2012/08/10
- [Qemu-devel] [RFC 03/20] target-i386: if x86_cpu_realize() failed report error and do cleanup, Igor Mammedov, 2012/08/10
- [Qemu-devel] [RFC 04/20] target-i386: filter out not TCG features if running without kvm at realize time, Igor Mammedov, 2012/08/10
- [Qemu-devel] [RFC 05/20] target-i386: move out CPU features initialization in separate func, Igor Mammedov, 2012/08/10
- [Qemu-devel] [RFC 06/20] target-i386: xlevel should be more than 0x80000000, move fixup into setter, Igor Mammedov, 2012/08/10
- Re: [Qemu-devel] [RFC 06/20] target-i386: xlevel should be more than 0x80000000, move fixup into setter,
Eduardo Habkost <=
- [Qemu-devel] [RFC 07/20] target-i386: convert cpuid features into properties, Igor Mammedov, 2012/08/10
- [Qemu-devel] [RFC 08/20] target-i386: convert 'hv_spinlocks' feature into property, Igor Mammedov, 2012/08/10
- [Qemu-devel] [RFC 09/20] target-i386: convert 'hv_relaxed' feature into property, Igor Mammedov, 2012/08/10
- [Qemu-devel] [RFC 11/20] target-i386: convert 'check' and 'enforce' features into properties, Igor Mammedov, 2012/08/10