[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-iotests: Save some sed processes
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-iotests: Save some sed processes |
Date: |
Thu, 09 Aug 2012 09:19:01 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 08/09/2012 09:01 AM, Kevin Wolf wrote:
> Instead of building a huge pipeline, just pass all expressions to a
> single sed process.
>
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> tests/qemu-iotests/common.rc | 20 ++++++++++----------
> 1 files changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> index 7782808..6b80516 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -105,16 +105,16 @@ _make_test_img()
>
> # XXX(hch): have global image options?
> $QEMU_IMG create -f $IMGFMT $extra_img_options $TEST_IMG $image_size | \
> - sed -e "s#$IMGPROTO:$TEST_DIR#TEST_DIR#g" | \
> + sed -e "s#$IMGPROTO:$TEST_DIR#TEST_DIR#g" \
and nice to get rid of that space-followed-by-TAB indent.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature