[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default mac
From: |
Max Filippov |
Subject: |
Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine |
Date: |
Thu, 9 Aug 2012 14:36:25 +0400 |
On Thu, Aug 9, 2012 at 11:43 AM, Markus Armbruster <address@hidden> wrote:
> Max Filippov <address@hidden> writes:
>
>> This fixes the following error:
>>
>> $ qemu-system-xtensa -cpu help
>> Segmentation fault
>
> main() attempts to cope with "no machine found", it just screws it up:
>
> if (machine->hw_version) {
> qemu_set_version(machine->hw_version);
> }
> [...]
> if (machine == NULL) {
> fprintf(stderr, "No machine found.\n");
> exit(1);
> }
>
> Probably broken in commit 93bfef4c, cc'ing its author.
>
> Of course, I don't mind you picking a default machine for xtensa, if
> that's what you want.
I guess it would make no harm. Also this way it will less likely break
next time,
and I remember Blue once wondered why xtensa doesn't have the default
machine.
--
Thanks.
-- Max