|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unplug |
Date: | Thu, 09 Aug 2012 09:40:10 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
Il 09/08/2012 09:28, liu ping fan ha scritto: >>> >> +static void >>> >> +pci_e1000_unmap(PCIDevice *p) >>> >> +{ >>> >> + /* DO NOT FREE anything!until refcnt=0 */ >>> >> + /* isolate from memory view */ >>> >> +} >> > >> > At least you need to call the superclass method. >> > > Refer to 0013-hotplug-introduce-qdev_unplug_complete-to-remove-dev.patch, > we have the following sequence > qdev_unmap->pci_unmap_device->pci_e1000_unmap. So pci_e1000_unmap > need not to do anything. But then this patch is unnecessary, isn't it? Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |