[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/11] Add migrate_set_cache_size command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 08/11] Add migrate_set_cache_size command |
Date: |
Mon, 06 Aug 2012 09:46:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 08/05/2012 03:13 AM, Orit Wasserman wrote:
> Change XBZRLE cache size in bytes (the size should be a power of 2, it will be
> rounded down to the nearest power of 2).
> If XBZRLE cache size is too small there will be many cache miss.
>
> New query-migrate-cache-size QMP command and 'info migrate_cache_size' HMP
> command to query cache value.
>
> +# @query-migrate-cache-size
> +#
> +# query XBZRLE cache size
> +#
> +# Returns: XBZRLE cache size in bytes
> +#
> +# Since: 1.2
> +##
> +{ 'command': 'query-migrate-cache-size', 'returns': 'int' }
This claims you return an int...
> +Example:
> +
> +-> { "execute": "migrate-set-cache-size", "arguments": { "value": 536870912
> } }
...but while this example passes an int,...
> +Example:
> +
> +-> { "execute": "query-migrate-cache-size" }
> +<- { "return": { "size":"67108864" } }
...this example is returning a JSON object '{"size":"67108864"}' instead
of an int '67108864'. Libvirt shouldn't care which of the two styles
you return, but it does need to be consistent between the schema, code,
and example (I didn't check the code to see which one of the two styles
was really in use).
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities, (continued)
- [Qemu-devel] [PATCH 03/11] Add XBZRLE documentation, Orit Wasserman, 2012/08/05
- [Qemu-devel] [PATCH 06/11] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions, Orit Wasserman, 2012/08/05
- [Qemu-devel] [PATCH 05/11] Add uleb encoding/decoding functions, Orit Wasserman, 2012/08/05
- [Qemu-devel] [PATCH 04/11] Add cache handling functions, Orit Wasserman, 2012/08/05
- [Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages, Orit Wasserman, 2012/08/05
- [Qemu-devel] [PATCH 07/11] Add XBZRLE to ram_save_block and ram_save_live, Orit Wasserman, 2012/08/05
- [Qemu-devel] [PATCH 08/11] Add migrate_set_cache_size command, Orit Wasserman, 2012/08/05
- Re: [Qemu-devel] [PATCH 08/11] Add migrate_set_cache_size command,
Eric Blake <=
- [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics, Orit Wasserman, 2012/08/05
- [Qemu-devel] [PATCH 11/11] Restart optimization on stage3 update version, Orit Wasserman, 2012/08/05