[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [untested PATCH] virtio: fix vhost handling
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [untested PATCH] virtio: fix vhost handling |
Date: |
Mon, 06 Aug 2012 15:20:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
Il 06/08/2012 14:48, Stefan Hajnoczi ha scritto:
>> > Interesting, I tested vhost (or thought so). Can you try this
>> > patch instead?
> Does this really make the code better than just reverting the patch?
The main problem here is that the current code has calls to
event_notifier_get_fd. These compile under Windows, but they will not
make sense when EventNotifier is ported to Windows because it will not
have a file descriptor. So I want to remove event_notifier_get_fd from
public code, and reverting the patch is a step backwards.
> I don't like this name because virtio-blk-data-plane also wants to use
> the ioeventfd. I suggest we call it use_handler (note logic is
> reversed from with_vhost).
Ok, noted.
Paolo