[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 27/34] qerror: add proper ErrorClass value for Q
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 27/34] qerror: add proper ErrorClass value for QERR_ macros |
Date: |
Thu, 02 Aug 2012 19:01:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> This commit replaces the place holder value for the ErrorClass
> argument with a proper ErrorClass value for all QERR_ macros.
>
> All current errors are mapped to GenericError, except for errors
> CommandNotFound, DeviceNotActive, DeviceNotFound, KVMMissingCap and
> MigrationExpected, which are maintained as they are today.
>
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
> qerror.h | 140
> +++++++++++++++++++++++++++++++--------------------------------
> 1 file changed, 70 insertions(+), 70 deletions(-)
>
> diff --git a/qerror.h b/qerror.h
> index bcc93f8..94346cb 100644
> --- a/qerror.h
> +++ b/qerror.h
> @@ -45,214 +45,214 @@ char *qerror_format(const char *fmt, QDict *error);
> * Use scripts/check-qerror.sh to check.
> */
> #define QERR_ADD_CLIENT_FAILED \
> - -1, "{ 'class': 'AddClientFailed', 'data': {} }"
> + ERROR_CLASS_GENERIC_ERROR, "{ 'class': 'AddClientFailed', 'data': {} }"
Now we have two different things called "class" here. Ugly. But only
until PATCH 31 gets rid of the old one. Okay.
[...]
- [Qemu-devel] [PATCH 23/34] qapi: don't convert enum strings to lowercase, (continued)
- [Qemu-devel] [PATCH 32/34] qerror: drop qerror_table and qerror_format(), Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 27/34] qerror: add proper ErrorClass value for QERR_ macros, Luiz Capitulino, 2012/08/01
- Re: [Qemu-devel] [PATCH 27/34] qerror: add proper ErrorClass value for QERR_ macros,
Markus Armbruster <=
- [Qemu-devel] [PATCH 28/34] error: add error_get_class(), Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 25/34] qerror: qerror_table: don't use C99 struct initializers, Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 34/34] error, qerror: drop QDict member, Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 26/34] error, qerror: add ErrorClass argument to error functions, Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 33/34] error: drop error_get_qobject()/error_set_qobject(), Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 24/34] qapi-schema: add ErrorClass enum, Luiz Capitulino, 2012/08/01
- [Qemu-devel] [PATCH 31/34] error, qerror: pass desc string to error calls, Luiz Capitulino, 2012/08/01