[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c |
Date: |
Wed, 01 Aug 2012 17:50:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 |
Am 01.08.2012 17:43, schrieb Anthony Liguori:
> Igor Mammedov <address@hidden> writes:
>
>> v2:
>> ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_new_cpu(),
>> to keep cpu_init implementation in -softmmu and -user targets the same
>> in single place and maintanable.
>>
>> v3:
>> reuse cpu_is_bsp() rather than open code check if apicbase has BSP bit set
>>
>> tree for testing:
>> https://github.com/imammedo/qemu/tree/x86_reset_v3
>>
>> comiple & run tested with x86_64-linux-user, x86_64-softmmu targets
>>
>> Igor Mammedov (2):
>> target-i386: move cpu halted decision into x86_cpu_reset
>> target-i386: move cpu_reset and reset callback to cpu.c
>
> Applied all. Thanks.
So do you intend to refactor all machines accordingly or leave it
inconsistent now?
Andreas
>
> Regards,
>
> Anthony Liguori
>
>>
>> hw/apic.h | 5 ++++-
>> hw/apic_common.c | 16 +++++++++++++---
>> hw/pc.c | 18 +-----------------
>> target-i386/cpu.c | 30 ++++++++++++++++++++++++++++++
>> target-i386/helper.c | 1 -
>> target-i386/kvm.c | 4 +++-
>> 6 files changed, 51 insertions(+), 23 deletions(-)
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c, Anthony Liguori, 2012/08/01
- Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c, Anthony Liguori, 2012/08/01
- Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c, Andreas Färber, 2012/08/01
- Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c, Anthony Liguori, 2012/08/01
- Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c, Andreas Färber, 2012/08/01
- Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c, Anthony Liguori, 2012/08/01
- Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c, Andreas Färber, 2012/08/01
- Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c, Peter Maydell, 2012/08/01
- Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c, Andreas Färber, 2012/08/01
- Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c, Igor Mammedov, 2012/08/02
- Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c, Andreas Färber, 2012/08/01