Re: [Qemu-devel] [PATCH V4 01/12] hw/sd.c: convert wp

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V4 01/12] hw/sd.c: convert wp_groups in SDState

From:	Peter Maydell
Subject:	Re: [Qemu-devel] [PATCH V4 01/12] hw/sd.c: convert wp_groups in SDState to bitfield
Date:	Tue, 31 Jul 2012 15:25:10 +0100

On 27 July 2012 20:29, Igor Mitsyanko <address@hidden> wrote:
> Representing each group write protection flag with only one bit instead of int
> variable significantly reduces memory consumption.

...and it looks much nicer too.

Reviewed-by: Peter Maydell <address@hidden>

-- PMM

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-devel] [PATCH V4 00/12] SD save/load support, SD qomification and bug fixes, Igor Mitsyanko, 2012/07/27
- [Qemu-devel] [PATCH V4 01/12] hw/sd.c: convert wp_groups in SDState to bitfield, Igor Mitsyanko, 2012/07/27
  - Re: [Qemu-devel] [PATCH V4 01/12] hw/sd.c: convert wp_groups in SDState to bitfield, Peter Maydell <=
- [Qemu-devel] [PATCH V4 02/12] hw/sd.c: make sd_wp_addr() accept 64 bit address argument, Igor Mitsyanko, 2012/07/27
  - Re: [Qemu-devel] [PATCH V4 02/12] hw/sd.c: make sd_wp_addr() accept 64 bit address argument, Peter Maydell, 2012/07/31
- [Qemu-devel] [PATCH V4 03/12] hw/sd.c: introduce wrapper for conversion address to wp group, Igor Mitsyanko, 2012/07/27
  - Re: [Qemu-devel] [PATCH V4 03/12] hw/sd.c: introduce wrapper for conversion address to wp group, Peter Maydell, 2012/07/31
- [Qemu-devel] [PATCH V4 04/12] hw/sd.c: favour SD card type (SDSC or SDHC) when performing erase, Igor Mitsyanko, 2012/07/27
  - Re: [Qemu-devel] [PATCH V4 04/12] hw/sd.c: favour SD card type (SDSC or SDHC) when performing erase, Markus Armbruster, 2012/07/31
    - Re: [Qemu-devel] [PATCH V4 04/12] hw/sd.c: favour SD card type (SDSC or SDHC) when performing erase, Igor Mitsyanko, 2012/07/31
  - Re: [Qemu-devel] [PATCH V4 04/12] hw/sd.c: favour SD card type (SDSC or SDHC) when performing erase, Peter Maydell, 2012/07/31
    - Re: [Qemu-devel] [PATCH V4 04/12] hw/sd.c: favour SD card type (SDSC or SDHC) when performing erase, Igor Mitsyanko, 2012/07/31
- [Qemu-devel] [PATCH V4 05/12] hw/sd.c: convert binary variables to bool, Igor Mitsyanko, 2012/07/27

Prev by Date: Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target
Next by Date: Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target
Previous by thread: [Qemu-devel] [PATCH V4 01/12] hw/sd.c: convert wp_groups in SDState to bitfield
Next by thread: [Qemu-devel] [PATCH V4 02/12] hw/sd.c: make sd_wp_addr() accept 64 bit address argument
Index(es):
- Date
- Thread