[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command |
Date: |
Fri, 27 Jul 2012 15:00:00 +0100 |
On 27 July 2012 14:37, Anthony Liguori <address@hidden> wrote:
> This command attempts to map to the behavior of -cpu ?. Unfortunately, the
> output of this command differs wildly across targets.
I've never really understood why so much of the cpu selection
logic is deferred to target-*...
> To accomodate this, we use a weak symbol to implement a default version of the
> command that fails with a QERR_NOT_SUPPORTED error code. Targets can then
> override and implement this command if it makes sense for them.
This is a bit of a weak reason (boom boom!) for requiring a platform
specific thing like weak symbols, though, and it's not how we handle
similar existing cases (eg see the configure/makefile logic for
memory_mapping.c vs memory_mapping-stub.c).
If having separate configure/make stuff for each of these things
sounds a bit heavyweight, we could just have a target-stubs.c which
#includes cpu.h and has a lot of
#ifndef TARGET_QUERY_CPUDEFS
[stub version]
#endif
#ifndef TARGET_GET_MEMORY_MAPPING
[stub version]
#endif
etc.
-- PMM
- [Qemu-devel] [PATCH 3/7] qapi: add query-machines command, (continued)
- [Qemu-devel] [PATCH 1/7] qmp: introduce device-list-properties command, Anthony Liguori, 2012/07/27
- [Qemu-devel] [PATCH 2/7] qapi: mark QOM commands stable, Anthony Liguori, 2012/07/27
- [Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command, Anthony Liguori, 2012/07/27
- [Qemu-devel] [PATCH 7/7] target-ppc: add implementation of query-cpudefs, Anthony Liguori, 2012/07/27
- [Qemu-devel] [PATCH 6/7] target-i386: add implementation of query-cpudefs, Anthony Liguori, 2012/07/27
- Re: [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need to parse -help output, Luiz Capitulino, 2012/07/27