[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] Introduce virtqueue_get_avail_bytes()
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] Introduce virtqueue_get_avail_bytes() |
Date: |
Thu, 26 Jul 2012 19:57:06 +0530 |
On (Fri) 06 Jul 2012 [16:07:06], Amit Shah wrote:
> The current virtqueue_avail_bytes() is a weird API: it's oddly-named:
> doesn't tell us what the API is going to do, and also suits just one
> use-case (that in virtio-net.c).
>
> Introduce virtqueue_get_avail_bytes(), which returns the number of
> bytes in the vq available for input as well as output.
> virtqueue_avail_bytes() is made a wrapper around this new function for
> now. It should be deprecated soon, though.
>
> Doing this will also help with the virtio-rng patch where a
> VirtQueueElement is popped only to find out what its size is. With
> this series applied, the popping (and the subsequent save/load of
> state for migration) isn't necessary.
>
> The virtio-serial-bus code becomes better too, that's patch 3 here.
>
> Please apply,
Ping again.
Amit