[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] kvm: Add documentation comment for kvm_irqc
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 6/6] kvm: Add documentation comment for kvm_irqchip_in_kernel() |
Date: |
Wed, 25 Jul 2012 17:40:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120601 Thunderbird/13.0 |
Am 25.07.2012 15:24, schrieb Peter Maydell:
> Now we've cleared out the architecture-independent uses of
> kvm_irqchip_in_kernel(), we can add a doc comment describing
> what it means.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> kvm.h | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
If you've cleared the arch-independent uses, can't it be moved out of
the generic kvm.h? Otherwise if just the commit message is confusing me:
>
> diff --git a/kvm.h b/kvm.h
> index 1449795..ae9df2d 100644
> --- a/kvm.h
> +++ b/kvm.h
> @@ -30,6 +30,17 @@ extern bool kvm_msi_via_irqfd_allowed;
>
> #if defined CONFIG_KVM || !defined NEED_CPU_H
> #define kvm_enabled() (kvm_allowed)
Could we add a white line here...
> +/**
> + * kvm_irqchip_in_kernel:
> + *
> + * Returns: true if the user asked us to create an in-kernel
> + * irqchip via the "kernel_irqchip=on" machine option.
> + * What this actually means is architecture and machine model
> + * specific: on PC, for instance, it means that the LAPIC,
> + * IOAPIC and PIT are all in kernel. This function should never
> + * be used from generic target-independent code: use one of the
> + * following functions or some other specific check instead.
> + */
> #define kvm_irqchip_in_kernel() (kvm_kernel_irqchip)
...and here, to better group the macros and their documentation?
Andreas
> /**
> * kvm_async_interrupt_injection:
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, (continued)
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Peter Maydell, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Peter Maydell, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Jan Kiszka, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Avi Kivity, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Peter Maydell, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Jan Kiszka, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Avi Kivity, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Peter Maydell, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Avi Kivity, 2012/07/25
[Qemu-devel] [PATCH 6/6] kvm: Add documentation comment for kvm_irqchip_in_kernel(), Peter Maydell, 2012/07/25
- Re: [Qemu-devel] [PATCH 6/6] kvm: Add documentation comment for kvm_irqchip_in_kernel(),
Andreas Färber <=
[Qemu-devel] [PATCH 5/6] kvm: Don't assume irqchip implies MSI routing via irqfds, Peter Maydell, 2012/07/25
[Qemu-devel] [PATCH 4/6] kvm: Don't assume irqchip-in-kernel implies irqfds, Peter Maydell, 2012/07/25
[Qemu-devel] [PATCH 3/6] kvm: Move kvm_allows_irq0_override() to target-i386, Peter Maydell, 2012/07/25
[Qemu-devel] [PATCH 1/6] kvm: Decouple 'interrupt injection is async' from 'kernel irqchip', Peter Maydell, 2012/07/25