[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into n
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c |
Date: |
Wed, 25 Jul 2012 15:19:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.6esrpre) Gecko/20120714 Thunderbird/10.0.6 |
On 07/24/12 17:35, Stefan Hajnoczi wrote:
> v2:
> * Change int64_t and unsigned int mess to int which is what VLAN IDs are
> today [Laszlo]
> * Remove bogus error_set() -> qerror_report() merge artifact [Laszlo]
> * Use net_hub_id_for_client(nc, NULL) == 0 instead of adding
> net_hub_port_peer_nc() [Laszlo]
> * Fix stray print_net_client(..., NetClientState *vc) argument name [Laszlo]
> * Consistently update vlan -> peer argument name [Laszlo]
> * Drop spurious closesocket(fd), probably merge conflict [Stefan]
I checked the interdiffs and my v1 comments.
Reviewed-by: Laszlo Ersek <address@hidden>
- [Qemu-devel] [PATCH v2 06/16] net: Convert qdev_prop_vlan to peer with hub, (continued)
- [Qemu-devel] [PATCH v2 06/16] net: Convert qdev_prop_vlan to peer with hub, Stefan Hajnoczi, 2012/07/24
- [Qemu-devel] [PATCH v2 07/16] net: Remove vlan code from net.c, Stefan Hajnoczi, 2012/07/24
- [Qemu-devel] [PATCH v2 14/16] net: cleanup deliver/deliver_iov func pointers, Stefan Hajnoczi, 2012/07/24
- [Qemu-devel] [PATCH v2 09/16] net: Rename non_vlan_clients to net_clients, Stefan Hajnoczi, 2012/07/24
- [Qemu-devel] [PATCH v2 11/16] net: Rename vc local variables to nc, Stefan Hajnoczi, 2012/07/24
- [Qemu-devel] [PATCH v2 10/16] net: Rename VLANClientState to NetClientState, Stefan Hajnoczi, 2012/07/24
- [Qemu-devel] [PATCH v2 15/16] net: determine if packets can be sent before net queue deliver packets, Stefan Hajnoczi, 2012/07/24
- [Qemu-devel] [PATCH v2 08/16] net: Remove VLANState, Stefan Hajnoczi, 2012/07/24
- [Qemu-devel] [PATCH v2 04/16] hub: Check that hubs are configured correctly, Stefan Hajnoczi, 2012/07/24
- Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c, Laszlo Ersek, 2012/07/24
- Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c,
Laszlo Ersek <=
- Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c, Stefan Hajnoczi, 2012/07/30