Re: [Qemu-devel] [PATCH V4 0/3] Block migration if any of the block device is busy

[Kevin Wolf]

Am 23.07.2012 16:22, schrieb address@hidden:
> From: Benoît Canet <address@hidden>
> 
> This patchset is designed to avoid starting a live migration while any of
> the block device is busy.
> 
> Tested with the following sequence:
> 
> QEMU 1.1.50 monitor - type 'help' for more information
> (qemu) block_stream virtio0 1k
> (qemu) migrate tcp:localhost:4444
> migrate: Migration is blocked by streaming
> (qemu)  block_job_cancel virtio0
> (qemu)  migrate tcp:localhost:4444
> migrate: Connection can not be completed immediately
> (qemu) 
> => migration then succeed

Maybe I'm missing the obvious, but why? Migration will stop the
streaming if it isn't restarted explicitly on the destination, but I
think that's expected.

Also, there are migration blockers. Wouldn't it be better to use them
instead of adding more special-case code to migration.c?

Kevin