[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/6] hw/arm_boot.c: Check for RAM sizes excee
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/6] hw/arm_boot.c: Check for RAM sizes exceeding ATAGS capacity |
Date: |
Wed, 18 Jul 2012 22:28:26 +1000 |
On Mon, Jul 16, 2012 at 11:24 PM, Peter Maydell
<address@hidden> wrote:
> The legacy ATAGS format for passing information to the kernel only
> allows RAM sizes which fit in 32 bits; enforce this restriction
> rather than silently doing something weird.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Peter A. G. Crosthwaite <address@hidden>
> ---
> hw/arm_boot.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/hw/arm_boot.c b/hw/arm_boot.c
> index 29ae324..af71ed6 100644
> --- a/hw/arm_boot.c
> +++ b/hw/arm_boot.c
> @@ -399,6 +399,12 @@ void arm_load_kernel(ARMCPU *cpu, struct arm_boot_info
> *info)
> bootloader[5] = dtb_start;
> } else {
> bootloader[5] = info->loader_start + KERNEL_ARGS_ADDR;
> + if (info->ram_size >= (1ULL << 32)) {
> + fprintf(stderr, "qemu: RAM size must be less than 4GB to
> boot"
> + " Linux kernel using ATAGS (try passing a device
> tree"
> + " using -dtb)\n");
> + exit(1);
> + }
> }
> bootloader[6] = entry;
> for (n = 0; n < sizeof(bootloader) / 4; n++) {
> --
> 1.7.5.4
>
- [Qemu-devel] [PATCH v2 0/6] arm_boot/vexpress-a15: Support >4GB of RAM, Peter Maydell, 2012/07/16
- [Qemu-devel] [PATCH v2 6/6] hw/vexpress.c: Allow >4GB of RAM for Cortex-A15 daughterboard, Peter Maydell, 2012/07/16
- [Qemu-devel] [PATCH v2 1/6] hw/arm_boot.c: Make ram_size a uint64_t, Peter Maydell, 2012/07/16
- [Qemu-devel] [PATCH v2 4/6] device_tree: Add support for reading device tree properties, Peter Maydell, 2012/07/16
- [Qemu-devel] [PATCH v2 2/6] hw/arm_boot.c: Consistently use ram_size from arm_boot_info struct, Peter Maydell, 2012/07/16
- [Qemu-devel] [PATCH v2 3/6] hw/arm_boot.c: Check for RAM sizes exceeding ATAGS capacity, Peter Maydell, 2012/07/16
- Re: [Qemu-devel] [PATCH v2 3/6] hw/arm_boot.c: Check for RAM sizes exceeding ATAGS capacity,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH v2 5/6] hw/arm_boot.c: Support DTBs which use 64 bit addresses, Peter Maydell, 2012/07/16