[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/4] exynos4210: Added SD host controller mod
|
From: |
Peter Crosthwaite |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 2/4] exynos4210: Added SD host controller model |
|
Date: |
Wed, 18 Jul 2012 17:13:18 +1000 |
Will merge Igors corrections into v6
Regards,
Peter
On Wed, Jul 18, 2012 at 1:04 AM, Peter Maydell <address@hidden> wrote:
> On 17 July 2012 15:58, Igor Mitsyanko <address@hidden> wrote:
>> On 07/17/2012 05:37 PM, Peter Maydell wrote:
>>> I would suggest two functions:
>>>
>>> int sdhci_slotint(SDHCIState *s)
>>> which just calculates and returns the external interrupt line state
>>> (might be able to make this 'static'), and
>
>> Ok, but I'd rather make sdhci_slotint() return uint8_t, to emphasize that
>> this function returns a value of hardware SLOTINT register.
>
> That's fine; the thing I want to avoid is having by-hand updates
> of slotint all over the code.
>
> -- PMM
[Qemu-devel] [PATCH v5 3/4] vl.c: allow for repeated -sd arguments, Peter A. G. Crosthwaite, 2012/07/05
[Qemu-devel] [PATCH v5 4/4] xilinx_zynq: Added SD controllers, Peter A. G. Crosthwaite, 2012/07/05