[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/5] vnc: add a more descriptive error message
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 3/5] vnc: add a more descriptive error message |
Date: |
Fri, 13 Jul 2012 11:38:00 +0100 |
From: Amos Kong <address@hidden>
Currently qemu outputs some low-level error in qemu-sockets.c
when failed to start vnc server.
eg. 'getaddrinfo(127.0.0.1,5902): Name or service not known'
Some libvirt users could not know what's happened with this
unclear error message. This patch added a more descriptive
error message.
Signed-off-by: Amos Kong <address@hidden>
Reviewed-by: Michael Tokarev <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
vl.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 2e140f5..46248b9 100644
--- a/vl.c
+++ b/vl.c
@@ -3584,8 +3584,11 @@ int main(int argc, char **argv, char **envp)
/* init remote displays */
if (vnc_display) {
vnc_display_init(ds);
- if (vnc_display_open(ds, vnc_display) < 0)
+ if (vnc_display_open(ds, vnc_display) < 0) {
+ fprintf(stderr, "Failed to start VNC server on `%s'\n",
+ vnc_display);
exit(1);
+ }
if (show_vnc_port) {
printf("VNC server running on `%s'\n", vnc_display_local_addr(ds));
--
1.7.10.4
- [Qemu-devel] [PULL 0/5] Trivial patches for July 3 to 13 2012, Stefan Hajnoczi, 2012/07/13
- [Qemu-devel] [PATCH 3/5] vnc: add a more descriptive error message,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 1/5] megasas: mark mfi_frame_desc as 'static', Stefan Hajnoczi, 2012/07/13
- [Qemu-devel] [PATCH 4/5] qemu-keymaps: Finnish keyboard mapping broken, Stefan Hajnoczi, 2012/07/13
- [Qemu-devel] [PATCH 2/5] bitops: Fix documentation, Stefan Hajnoczi, 2012/07/13
- [Qemu-devel] [PATCH 5/5] make: Remove 'build-all' rule, Stefan Hajnoczi, 2012/07/13
- Re: [Qemu-devel] [PULL 0/5] Trivial patches for July 3 to 13 2012, Blue Swirl, 2012/07/14