[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 19/21] Implement "info memtotal" and "que
From: |
Vasilis Liaskovitis |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 19/21] Implement "info memtotal" and "query-memtotal" |
Date: |
Wed, 11 Jul 2012 18:55:15 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi,
On Wed, Jul 11, 2012 at 09:14:29AM -0600, Eric Blake wrote:
> On 07/11/2012 04:32 AM, Vasilis Liaskovitis wrote:
> > Returns total memory of guest in bytes, including hotplugged memory.
> >
> > Signed-off-by: Vasilis Liaskovitis <address@hidden>
>
> Should this instead be merged with query-balloon output, so that we have
> a single command that shows all aspects of memory usage (both balloon
> and hotplug at once)?
>
>
> > @@ -1888,3 +1888,15 @@
> > # Since: 1.1.3
> > ##
> > { 'command': 'query-memhp', 'returns': ['MemHpInfo'] }
> > +
> > +##
> > +# @query-memtotal:
>
> A more generic name might be 'query-memory', especially if we merge
> balloon and hotplug information into one command.
"query-memory" sounds reasonable to me.
"query-balloon" should also be updated to show the correct memory.
Do you foresee any issues with merging them? the "query-memory" command
should work independently of the balloon driver.
> > +#
> > +# Returns total memory in bytes, including hotplugged dimms
> > +#
> > +# Returns: a l
>
> truncated
sorry about that.
thanks,
- Vasilis
>
> --
> Eric Blake address@hidden +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
>
>
- [Qemu-devel] [RFC PATCH v2 11/21] Implement dimm_add and dimm_del hmp/qmp commands, (continued)
- [Qemu-devel] [RFC PATCH v2 11/21] Implement dimm_add and dimm_del hmp/qmp commands, Vasilis Liaskovitis, 2012/07/11
- [Qemu-devel] [RFC PATCH v2 07/21] acpi_piix4: Implement memory device hotplug registers, Vasilis Liaskovitis, 2012/07/11
- [Qemu-devel] [RFC PATCH v2 16/21] acpi_piix4: Update dimm state on VM reboot, Vasilis Liaskovitis, 2012/07/11
- [Qemu-devel] [RFC PATCH v2 13/21] Implement memory hotplug notification lists, Vasilis Liaskovitis, 2012/07/11
- [Qemu-devel] [RFC PATCH v2 15/21] acpi_piix4: _OST dimm support, Vasilis Liaskovitis, 2012/07/11
- [Qemu-devel] [RFC PATCH v2 18/21] acpi_piix4: Update dimm bitmap state on hot-remove fail, Vasilis Liaskovitis, 2012/07/11
- [Qemu-devel] [RFC PATCH v2 19/21] Implement "info memtotal" and "query-memtotal", Vasilis Liaskovitis, 2012/07/11
- [Qemu-devel] [RFC PATCH v2 21/21] Implement mem_increase, mem_decrease hmp/qmp commands, Vasilis Liaskovitis, 2012/07/11
- [Qemu-devel] [RFC PATCH v2 20/21] Implement -dimms, -dimmspop command line options, Vasilis Liaskovitis, 2012/07/11
- Re: [Qemu-devel] [RFC PATCH v2 00/21] ACPI memory hotplug, Blue Swirl, 2012/07/12