Re: [Qemu-devel] [PATCH] pseries: Add support for new KVM hash table control call

[Benjamin Herrenschmidt]

On Wed, 2012-06-27 at 22:10 +1000, Benjamin Herrenschmidt wrote:
> From: David Gibson <address@hidden>
> 
> This adds support for then new "reset htab" ioctl which allows qemu
> to properly cleanup the MMU hash table when the guest is reset. With
> the corresponding kernel support, reset of a guest now works properly.
> 
> This also paves the way for indicating a different size hash table
> to the kernel and for the kernel to be able to impose limits on
> the requested size.

Alex, this has a bug, if you already applied it, please sneak:

> +int kvmppc_reset_htab(int shift_hint)
> +{
> +    uint32_t shift = shift_hint;
> +
> +    if (kvm_check_extension(kvm_state, KVM_CAP_PPC_ALLOC_HTAB)) {

The above shall be if (kvm_enabled() && ....

Else it will segfault in kvm_check_extension

Or let me know if I should re-submit.

Cheers,
Ben.