[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v16 8/9] Add set_cachesize command
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PATCH v16 8/9] Add set_cachesize command |
Date: |
Tue, 10 Jul 2012 08:15:40 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
On 07/09/2012 11:59 PM, Eric Blake wrote:
> On 07/09/2012 12:22 PM, Orit Wasserman wrote:
>> Change XBZRLE cache size in bytes (the size should be a power of 2).
>> If XBZRLE cache size is too small there will be many cache miss.
>>
>> Signed-off-by: Benoit Hudzia <address@hidden>
>> Signed-off-by: Petter Svard <address@hidden>
>> Signed-off-by: Aidan Shribman <address@hidden>
>> Signed-off-by: Orit Wasserman <address@hidden>
>
>> +++ b/qapi-schema.json
>> @@ -1390,6 +1390,22 @@
>> { 'command': 'migrate_set_speed', 'data': {'value': 'int'} }
>
> We are copying after bad practice, but...
>
>>
>> ##
>> +# @migrate_set_cachesize
>
> ...new QMP commands should prefer '-' over '_'. While the HMP version
> is fine with migrate_set_cachesize, the QMP command should be
> migrate-set-cachesize (or even 'migrate-set-cache-size').
>
I will change it
Thanks,
Orit
>
>> +
>> +Set cache size to be used by XBZRLE migration, the cache size will be round
>> down
>
> s/round/rounded/
>
- [Qemu-devel] [PATCH v16 0/9] XBZRLE delta for live migration of large memory app, Orit Wasserman, 2012/07/09
- [Qemu-devel] [PATCH v16 1/9] Add migration capabilities, Orit Wasserman, 2012/07/09
- [Qemu-devel] [PATCH v16 2/9] Add XBZRLE documentation, Orit Wasserman, 2012/07/09
- [Qemu-devel] [PATCH v16 4/9] Add uleb encoding/decoding functions, Orit Wasserman, 2012/07/09
- [Qemu-devel] [PATCH v16 3/9] Add cache handling functions, Orit Wasserman, 2012/07/09
- [Qemu-devel] [PATCH v16 5/9] Change ram_save_block to return -1 if there are no more changes, Orit Wasserman, 2012/07/09
- [Qemu-devel] [PATCH v16 6/9] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions, Orit Wasserman, 2012/07/09
- [Qemu-devel] [PATCH v16 7/9] Add XBZRLE to ram_save_block and ram_save_live, Orit Wasserman, 2012/07/09
- [Qemu-devel] [PATCH v16 8/9] Add set_cachesize command, Orit Wasserman, 2012/07/09
- [Qemu-devel] [PATCH v16 9/9] Add XBZRLE statistics, Orit Wasserman, 2012/07/09