[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] file_ram_alloc(): use g_strdup_printf() ins
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 2/6] file_ram_alloc(): use g_strdup_printf() instead of asprintf() |
Date: |
Tue, 3 Jul 2012 19:16:56 +0000 |
On Mon, Jul 2, 2012 at 6:06 PM, Eduardo Habkost <address@hidden> wrote:
> Cc: Blue Swirl <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
Acked-by: Blue Swirl <address@hidden>
> ---
> exec.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index c8bfd27..d856325 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -24,6 +24,9 @@
> #include <sys/mman.h>
> #endif
>
> +#include <glib.h>
> +#include <glib/gprintf.h>
> +
> #include "qemu-common.h"
> #include "cpu.h"
> #include "tcg.h"
> @@ -2357,7 +2360,7 @@ static void *file_ram_alloc(RAMBlock *block,
> ram_addr_t memory,
> const char *path)
> {
> - char *filename;
> + gchar *filename;
> void *area;
> int fd;
> #ifdef MAP_POPULATE
> @@ -2379,18 +2382,15 @@ static void *file_ram_alloc(RAMBlock *block,
> return NULL;
> }
>
> - if (asprintf(&filename, "%s/qemu_back_mem.XXXXXX", path) == -1) {
> - return NULL;
> - }
> -
> + filename = g_strdup_printf("%s/qemu_back_mem.XXXXXX", path);
> fd = mkstemp(filename);
> if (fd < 0) {
> perror("unable to create backing store for hugepages");
> - free(filename);
> + g_free(filename);
> return NULL;
> }
> unlink(filename);
> - free(filename);
> + g_free(filename);
>
> memory = (memory + hpagesize - 1) & ~(hpagesize - 1);
>
> --
> 1.7.10.4
>
- [Qemu-devel] [RFC PATCH 0/6] option to not remove files inside -mem-path dir (v2), Eduardo Habkost, 2012/07/02
- [Qemu-devel] [PATCH 1/6] file_ram_alloc(): coding style fixes, Eduardo Habkost, 2012/07/02
- [Qemu-devel] [PATCH 4/6] file_ram_alloc: change length argument to size_t (v2), Eduardo Habkost, 2012/07/02
- [Qemu-devel] [RFC PATCH 6/6] add -keep-mem-path-files option (v2), Eduardo Habkost, 2012/07/02
- [Qemu-devel] [PATCH 2/6] file_ram_alloc(): use g_strdup_printf() instead of asprintf(), Eduardo Habkost, 2012/07/02
- Re: [Qemu-devel] [PATCH 2/6] file_ram_alloc(): use g_strdup_printf() instead of asprintf(),
Blue Swirl <=
- [Qemu-devel] [PATCH 3/6] vl.c: change mem_prealloc to bool (v2), Eduardo Habkost, 2012/07/02
- [Qemu-devel] [PATCH 5/6] file_ram_alloc(): extract temporary-file creation code to separate function (v2), Eduardo Habkost, 2012/07/02
- Re: [Qemu-devel] [RFC PATCH 0/6] option to not remove files inside -mem-path dir (v2), Daniel P. Berrange, 2012/07/02