[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 02/13] Add migration capabilites
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v13 02/13] Add migration capabilites |
Date: |
Wed, 27 Jun 2012 09:02:26 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 06/27/2012 04:34 AM, Orit Wasserman wrote:
> Add migration capabilites that can be queried by the management.
s/capabilites/capabilities/
> The management can query the source QEMU and the destination QEMU in order to
> verify both support some migration capability (currently only XBZRLE).
> The managment can enable a capability for the next migration by using
s/managment/management/
> migrate_set_parameter command.
>
> Signed-off-by: Orit Wasserman <address@hidden>
> +++ b/qapi-schema.json
> @@ -286,7 +286,7 @@
> ##
> { 'type': 'MigrationInfo',
> 'data': {'*status': 'str', '*ram': 'MigrationStats',
> - '*disk': 'MigrationStats'} }
> + '*disk': 'MigrationStats', '*params':
> ['MigrationCapabilityInfo']} }
'params' is an abbreviation, and QMP tends to avoid those. Furthermore,
I think it might be better naming this array '*capabilities' instead of
'*params'.
> ##
> +# @MigrationCapability
> +#
> +# Migration capabilities enumaration
s/enumaration/enumeration/
> +# Set the following migration parameters (like xbzrle)
> +##
> +# Since: 1.2
> +##
> +{ 'command': 'migrate-set-parameters', 'data': { 'parameters':
> ['MigrationCapabilityInfo'] } }
Here, you at least spelled it out as 'parameters' instead of 'params',
but I still think 'capabilities' would be a more consistent name for the
array.
> +SQMP
> +migrate_set_parameters
> +-------
> +
> +Enable migration capabilities
Thanks to the state portion of each MigrationCapabilityInfo, this
command can actually enable _or disable_ migration capabilities.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v13 00/13] XBZRLE delta for live migration of large memory app, Orit Wasserman, 2012/06/27
- [Qemu-devel] [PATCH v13 01/13] Add MigrationParams structure, Orit Wasserman, 2012/06/27
- [Qemu-devel] [PATCH v13 03/13] Add XBZRLE documentation, Orit Wasserman, 2012/06/27
- [Qemu-devel] [PATCH v13 02/13] Add migration capabilites, Orit Wasserman, 2012/06/27
- Re: [Qemu-devel] [PATCH v13 02/13] Add migration capabilites,
Eric Blake <=
- [Qemu-devel] [PATCH v13 04/13] Add cache handling functions, Orit Wasserman, 2012/06/27
- Re: [Qemu-devel] [PATCH v13 04/13] Add cache handling functions, Blue Swirl, 2012/06/27
- [Qemu-devel] [PATCH v13 06/13] Add save_block_hdr function, Orit Wasserman, 2012/06/27
- [Qemu-devel] [PATCH v13 05/13] Add uleb encoding/decoding functions, Orit Wasserman, 2012/06/27