[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/7] qapi: Add pass-fd QMP command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/7] qapi: Add pass-fd QMP command |
Date: |
Mon, 25 Jun 2012 10:13:22 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 06/25/2012 09:34 AM, Kevin Wolf wrote:
> Am 25.06.2012 16:51, schrieb Corey Bryant:
>> Thanks for catching this. I'll fix this in v5. In terms of platforms
>> that support dup3 vs dup2, I'm assuming the following preprocessor
>> checks will do what we need:
>>
>> #if defined(__linux__) || defined(__CYGWIN__)
>> dup3(fd, monfd->fd, O_CLOEXEC)
>> #else
>> dup2()+fcntl(F_GETFD/F_SETFD)
>> #endif
>
> Checking for dup3() in configure might be the better option. It's not
> like it has been there forever, even on Linux.
Agreed. Furthermore, since dup3() has been proposed for addition into
POSIX[1], it won't be long before other platforms add it. Always favor
feature checks (a configure probe for dup3) over platform checks
(hard-coding the assumption that Linux and Cygwin are the only platforms
that will ever provide it).
[1] http://austingroupbugs.net/view.php?id=411
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 4/7] qapi: Re-arrange monitor.c functions, (continued)
[Qemu-devel] [PATCH v4 6/7] block: Convert open calls to qemu_open, Corey Bryant, 2012/06/22
[Qemu-devel] [PATCH v4 3/7] qapi: Add pass-fd QMP command, Corey Bryant, 2012/06/22
Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd, Daniel P. Berrange, 2012/06/26
- Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd, Kevin Wolf, 2012/06/26
- Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd, Luiz Capitulino, 2012/06/26
- Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd, Corey Bryant, 2012/06/26
- Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd, Eric Blake, 2012/06/26
- Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd, Kevin Wolf, 2012/06/27
- Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd, Daniel P. Berrange, 2012/06/27
- Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd, Kevin Wolf, 2012/06/27
- Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd, Corey Bryant, 2012/06/28