[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-ppc: Fix 2nd parameter for tcg_gen_shri_
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-ppc: Fix 2nd parameter for tcg_gen_shri_tl |
|
Date: |
Mon, 25 Jun 2012 14:17:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 24.06.2012 17:14, schrieb Alexander Graf:
> On 24.06.2012, at 16:18, Stefan Weil <address@hidden> wrote:
>
>> This fixes a compiler error when QEMU was configured with --enable-debug.
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>>
>> Alex, please review. It fixes the compiler error, but I did the change
>> simply by comparision with other functions, so I have no idea whether
>> it is really correct.
>
> Looks good at a first glance, but will verify tonight. Thanks a lot for
> catching it!
>
> I guess we should add an --enable-debug build to buildbot.
Blue/Stefan, could you set up a feature page on the Wiki for the AREG0
refactoring? Then we could document what maintainers/testers need to
verify for the next series there.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg