[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-ppc: Fix build with --enable-debug
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH] target-ppc: Fix build with --enable-debug |
Date: |
Sun, 24 Jun 2012 16:04:28 +0000 |
On Sun, Jun 24, 2012 at 2:04 PM, Stefan Weil <address@hidden> wrote:
> The order of the arguments was wrong (copy+paste error).
Confirmed, a bug with
d0f1562d6ace0fdb7d2db190dd5a9a2e7492c3b3
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>
> Hi Alex, hi Blue,
>
> there is still one more bug for target-ppc with --enable-debug,
> so strictly speaking, the subject is not correct: the patch
> fixes the build only partially.
>
> Regards,
> Stefan
>
> target-ppc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 73ee74b..91eb7a0 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -5794,7 +5794,7 @@ static void gen_mtdcrux(DisasContext *ctx)
> {
> /* NIP cannot be restored if the memory exception comes from an helper */
> gen_update_nip(ctx, ctx->nip - 4);
> - gen_helper_store_dcr(cpu_gpr[rA(ctx->opcode)], cpu_env,
> + gen_helper_store_dcr(cpu_env, cpu_gpr[rA(ctx->opcode)],
> cpu_gpr[rS(ctx->opcode)]);
> /* Note: Rc update flag set leads to undefined state of Rc0 */
> }
> --
> 1.7.10
>