[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server |
Date: |
Thu, 21 Jun 2012 10:59:27 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jun 21, 2012 at 12:57:44PM +0300, Michael Tokarev wrote:
> 20.06.2012 16:24, Daniel P. Berrange wrote:
> > delete mode 100644 ui/vnc-jobs-async.c
> > delete mode 100644 ui/vnc-jobs-sync.c
> > create mode 100644 ui/vnc-jobs.c
>
> Is there a reason to rename vnc-jobs-foo.c to vnc-jobs.c ?
The corresponding header file is vnc-jobs.h, and since we only
have one impl of it now, using the same name is normal practice.
> I'd leave it alone at this stage, omiting just the rename...
I disagree, GIT handles renames like this fine, so there's no
reason not to do this.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|