[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/13] iommu: Make sglists and dma_bdrv helpers
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [PATCH 05/13] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers |
Date: |
Thu, 21 Jun 2012 07:37:14 +1000 |
On Wed, 2012-06-20 at 16:21 -0500, Anthony Liguori wrote:
> Again, you return an error but ignore it now.
>
> In the very least, on error you should scrub the passed in buffer to avoid
> leaking data to the guest.
>
> You can imagine a malicious guest programming the IOMMU with invalid mappings
> and then doing DMA operations in order to read memory from the host QEMU
> process.
Cleaning the buffer is easy, I'll add that. Returning an error sounds
non-trivial with the current interface.
Cheers,
Ben.
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, (continued)
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/20
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Anthony Liguori, 2012/06/20
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/20
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Michael S. Tsirkin, 2012/06/21
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Anthony Liguori, 2012/06/21
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Michael S. Tsirkin, 2012/06/21
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/21
- Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions, Gerd Hoffmann, 2012/06/21
[Qemu-devel] [PATCH 05/13] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers, Benjamin Herrenschmidt, 2012/06/19
[Qemu-devel] [PATCH 06/13] ide/ahci: Use universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/19
[Qemu-devel] [PATCH 09/13] iommu: Add facility to cancel in-use dma memory maps, Benjamin Herrenschmidt, 2012/06/19
[Qemu-devel] [PATCH 08/13] iommu: Introduce IOMMU emulation infrastructure, Benjamin Herrenschmidt, 2012/06/19
[Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/19