Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

[Anthony Liguori]

On 06/20/2012 09:51 AM, Andreas Färber wrote:
> Am 20.06.2012 16:44, schrieb Anthony Liguori:
> > diff --git a/hw/kvm/Makefile.objs b/hw/kvm/Makefile.objs
> > index 226497a..cf734ba 100644
> > --- a/hw/kvm/Makefile.objs
> > +++ b/hw/kvm/Makefile.objs
> > @@ -1 +1 @@
> > -obj-$(CONFIG_KVM) += clock.o apic.o i8259.o ioapic.o i8254.o
> > +obj-$(CONFIG_I386) += clock.o apic.o i8259.o ioapic.o i8254.o
>
> NACK. As long as the CPUState conversion is not completed (which after
> part 4 will take some time still) any user of CPUArchState must be
> compiled per target, not per base target. It may or may not work
> depending on fields accessed, but it is architecturally wrong.

It's admittedly confusing.

obj-y => this is built per-target (there is no concept of per-base target)

hw-obj-y => this is built once for 32-bit, once for 64-bit

common-obj-y => this is built once for all targets

CONFIG_I386=y if target arch == i386 or base arch == i386.

Regards.

Anthony Liguori

> Andreas