[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/5] qapi: Add pass-fd QMP command
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/5] qapi: Add pass-fd QMP command |
Date: |
Fri, 15 Jun 2012 13:26:05 -0300 |
On Fri, 15 Jun 2012 11:29:03 -0400
Corey Bryant <address@hidden> wrote:
> >> I'm not clear on what the problem is with returning the same error class
> >> for two different errors. Could you explain? I don't have a problem
> >> changing it if it's an issue.
> >
> > Because an mngt app/user won't know if what has happened was that the fd
> > name
> > is invalid or if the fd name already exists.
> >
>
> I agree, it makes sense so the management app can program based on the
> error class. It just seems like the error classes in general should be
> able to be used multiple times if it fits, especially if we're trying to
> avoid having too specific errors.
>
> Maybe (in the future) something like a sub-class could be used? In other
> words to allow using the same error class with unique sub-classes.
There's a discussion going on which is more or less the same topic:
http://lists.gnu.org/archive/html/qemu-devel/2012-06/msg02243.html
[Qemu-devel] [PATCH v3 4/5] block: Convert open calls to qemu_open, Corey Bryant, 2012/06/14
[Qemu-devel] [PATCH v3 5/5] block: Prevent /dev/fd/X filename from being detected as floppy, Corey Bryant, 2012/06/14
[Qemu-devel] [PATCH v3 3/5] osdep: Enable qemu_open to dup pre-opened fd, Corey Bryant, 2012/06/14