[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 06/10] ISCSI: force use of sg for SMC and SSC device
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 06/10] ISCSI: force use of sg for SMC and SSC devices |
Date: |
Tue, 12 Jun 2012 18:42:38 +0200 |
From: Ronnie Sahlberg <address@hidden>
If the device we open is a SMC or SSC device, then force the use of sg. We
dont have any medium changer or tape emulation so only passthrough via
real sg or scsi-generic via iscsi would work anyway.
Forcing sg also makes qemu skip trying to read from the device to guess
the image format by reading from the device (find_image_format()).
SMC devices do not implement READ6/10/12/16 so it is not possible to
read from them (SSC have different CDBs).
With this patch I can successfully manage a SMC device wiht iscsi in
passthrough mode.
Signed-off-by: Ronnie Sahlberg <address@hidden>
[Added TYPE_TAPE handling - Paolo]
Signed-off-by: Paolo Bonzini <address@hidden>
---
block/iscsi.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index 029739e..ac65277 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1022,6 +1022,16 @@ static int iscsi_open(BlockDriverState *bs, const char
*filename, int flags)
if (iscsi_url != NULL) {
iscsi_destroy_url(iscsi_url);
}
+
+ /* Medium changer or tape. We dont have any emulation for this so this must
+ * be sg ioctl compatible. We force it to be sg, otherwise qemu will try
+ * to read from the device to guess the image format.
+ */
+ if (iscsilun->type == TYPE_MEDIUM_CHANGER ||
+ iscsilun->type == TYPE_TAPE) {
+ bs->sg = 1;
+ }
+
return 0;
failed:
--
1.7.10.2
- [Qemu-devel] [PULL 00/10] SCSI updates for 2012-06-12, Paolo Bonzini, 2012/06/12
- [Qemu-devel] [PATCH 01/10] scsi: simplify handling of the VPD page length field, Paolo Bonzini, 2012/06/12
- [Qemu-devel] [PATCH 03/10] atapi: implement READ DISC INFORMATION, Paolo Bonzini, 2012/06/12
- [Qemu-devel] [PATCH 02/10] scsi: add a qdev property for the disk's WWN, Paolo Bonzini, 2012/06/12
- [Qemu-devel] [PATCH 04/10] scsi-disk: implement READ DISC INFORMATION, Paolo Bonzini, 2012/06/12
- [Qemu-devel] [PATCH 06/10] ISCSI: force use of sg for SMC and SSC devices,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 05/10] ISCSI: Add SCSI passthrough via scsi-generic to libiscsi, Paolo Bonzini, 2012/06/12
- [Qemu-devel] [PATCH 07/10] megasas: Add header file, Paolo Bonzini, 2012/06/12
- [Qemu-devel] [PATCH 08/10] megasas: LSI Megaraid SAS HBA emulation, Paolo Bonzini, 2012/06/12
- [Qemu-devel] [PATCH 10/10] virtio-scsi: do not crash on adding buffers to the event queue, Paolo Bonzini, 2012/06/12
- [Qemu-devel] [PATCH 09/10] megasas: Add trace events, Paolo Bonzini, 2012/06/12
- Re: [Qemu-devel] [PULL 00/10] SCSI updates for 2012-06-12, Anthony Liguori, 2012/06/20