qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC] QOMification of AXI stream


From: Avi Kivity
Subject: Re: [Qemu-devel] [RFC] QOMification of AXI stream
Date: Tue, 12 Jun 2012 12:51:24 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0

On 06/11/2012 09:36 PM, Anthony Liguori wrote:
>>
>> cpu_physical_memory_rw() would be implemented as
>> memory_region_rw(system_memory, ...) while pci_dma_rw() would be
>> implemented as memory_region_rw(pcibm, ...).  This would allow different
>> address transformations for the two accesses.
> 
> BTW, the main problem with the memory API right now is that there isn't
> a 'MemoryRegion *mr' as the first argument to the dispatch functions. 

Why is it a problem?

> This could be fixed by introducing yet another set of function pointers
> and keeping the existing callers unchanged though.

I prefer a full s///, I hate the huge number of thunks we go through to
deliver some transaction.

Note we had a *mr parameter originally, it was removed in favour of *opaque.


-- 
error compiling committee.c: too many arguments to function





reply via email to

[Prev in Thread] Current Thread [Next in Thread]