Re: [Qemu-devel] [PATCH 4/8] s390: stop target cpu on sigp initial reset

[Alexander Graf]

Jens Freimann wrote:
> From: Christian Borntraeger <address@hidden>
>
> We must not run the target cpu after an initial reset. This makes
> system_reset more reliable for smp guests.
>   

Why?

Alex

> Signed-off-by: Christian Borntraeger <address@hidden>
> ---
>  target-s390x/kvm.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
> index 93a8431..73cfd1f 100644
> --- a/target-s390x/kvm.c
> +++ b/target-s390x/kvm.c
> @@ -318,6 +318,7 @@ static int s390_cpu_initial_reset(CPUS390XState *env)
>  {
>      int i;
>  
> +    s390_del_running_cpu(env);
>      if (kvm_vcpu_ioctl(env, KVM_S390_INITIAL_RESET, NULL) < 0) {
>          perror("cannot init reset vcpu");
>      }
>