[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] fdc: use LOG_UNIMP logging
|
From: |
Blue Swirl |
|
Subject: |
Re: [Qemu-devel] [PATCH 5/6] fdc: use LOG_UNIMP logging |
|
Date: |
Thu, 7 Jun 2012 21:07:36 +0000 |
On Mon, Jun 4, 2012 at 9:36 AM, Kevin Wolf <address@hidden> wrote:
> Am 03.06.2012 19:38, schrieb Blue Swirl:
>> Convert uses of FLOPPY_ERROR to either FLOPPY_DPRINTF
>> (for implemented cases) or to use LOG_UNIMP (unimplemented).
>>
>> Signed-off-by: Blue Swirl <address@hidden>
>
> I would suggest that you check the messages of those cases that became
> FLOPPY_DPRINTF(). Originally the macro printed "FLOPPY ERROR: " and now
> it's not even mentioned any more that it is an error message, making
> messages like "writing sector %d" totally misleading.
Is that an error condition at all? It looks like just debugging.
>
> If you fix that up:
>
> Acked-by: Kevin Wolf <address@hidden>