qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netde


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing
Date: Wed, 06 Jun 2012 16:09:26 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1

Il 06/06/2012 15:03, Laszlo Ersek ha scritto:
> OK so this is what I see:
> 
> (a) add < 0 checks to <http://patchwork.ozlabs.org/patch/150427/> and
>     include it in the series,
> (b) make all Netdev integer types as strict as possible, remove
>     superfluous checks,
> (c) render NetLegacy::name optional.

Yep.

> How do I lay out (a)? Should I include the patch verbatim first (with
> proper From: and Signed-off-by: lines) and then modify it in a small
> followup or squash those two and... what? :)

As you prefer.  In either case leave the From to Michael and add your
Signed-off-by, which I guess is what you meant by "proper".

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]