Re: [Qemu-devel] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback

[Peter Maydell]

On 23 May 2012 04:08, Andreas Färber <address@hidden> wrote:
> +void cpu_tlb_flush(CPUState *cpu, bool flush_global)
> +{
> +    CPUClass *cc = CPU_GET_CLASS(cpu);
> +
> +    g_assert(cc->tlb_flush != NULL);
> +
> +    cc->tlb_flush(cpu, flush_global);
> +}

This needs to be able to call tlb_flush() itself
rather than having to have every single subclass of CPUState
implement an identical tlb_flush method. You could do this
if there was a CPU_GET_ENV()...

> 16 files changed, 173 insertions(+), 0 deletions(-)

...which is a lot of extra code to be inserting to do nothing
that's specific to a particular target.

-- PMM