qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies
Date: Tue, 29 May 2012 04:50:45 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

On 05/29/2012 04:47 AM, Andreas Färber wrote:
Am 29.05.2012 11:43, schrieb Paolo Bonzini:
Il 29/05/2012 11:28, Andreas Färber ha scritto:
Am 29.05.2012 09:05, schrieb Gerd Hoffmann:
-       rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d 
net/*.o net/*.d fsdev/*.o fsdev/*.d ui/*.o ui/*.d qapi/*.o qapi/*.d qga/*.o 
qga/*.d
-       rm -f qom/*.o qom/*.d
+       rm -f slirp/*.o audio/*.o block/*.o net/*.o fsdev/*.o ui/*.o qapi/*.o 
qga/*.o
+       rm -f qom/*.o

I think this is calling for a centrally maintained (or automatically
derived) list of build directories.

Quite difficult with the abuse of vpath that we currently have... but we
can still proceed incrementally.

For 1.1 I was thinking of something like

BUILDSUBDIRS=slirp audio block net fsdev ui qapi qga qom

        for dir in $(BUILDSUBDIRS); do \
                rm -rf $dir/*.o $dir/*.d; \
        done

which possibly could also be reused for the list of *.d includes with
some clever macro usage.

I'd prefer not to make this change in 1.1.0 as this doesn't seem to be a release blocker to me. I'd rather do something more significant in 1.2 and backport to a 1.1.1 release.

Regards,

Anthony Liguori


Andreas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]