Re: [Qemu-devel] [PATCH 03/10] qom: push error reporting to object_property_find

[Andreas Färber]

Am 26.05.2012 11:58, schrieb Paolo Bonzini:
> Il 25/05/2012 18:05, Andreas Färber ha scritto:
>>>> @@ -698,10 +702,8 @@ void object_property_del(Object *obj, const char 
>>>> *name, Error **errp)
>>>>  void object_property_get(Object *obj, Visitor *v, const char *name,
>>>>                           Error **errp)
>>>>  {
>>>> -    ObjectProperty *prop = object_property_find(obj, name);
>>>> -
>>>> +    ObjectProperty *prop = object_property_find(obj, name, errp);
>>>>      if (prop == NULL) {
>>>> -        error_set(errp, QERR_PROPERTY_NOT_FOUND, "", name);
>>>>          return;
>>>>      }
>>>>  
>> Currently it doesn't happen, but I wonder if we should check
>> error_is_set(errp) instead of or in addition to prop == NULL now?
>> Applies to all callsites above and below.
> 
> No, because errp can be NULL.

Ah, see it now. I fixed up the duplicated ifs and applied it to qom-next:
http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg