qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/10] qdev: move bulk of qdev-properties.c to q


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 07/10] qdev: move bulk of qdev-properties.c to qom/object.c
Date: Fri, 25 May 2012 15:36:07 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1

Il 25/05/2012 15:32, Andreas Färber ha scritto:
> Am 23.05.2012 17:44, schrieb Paolo Bonzini:
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>>  hw/qdev-properties.c  |  487 
>> +++++--------------------------------------------
>>  hw/qdev.c             |   47 +----
>>  hw/qdev.h             |   87 ---------
>>  include/qemu/object.h |   98 ++++++++++
>>  qom/object.c          |  459 ++++++++++++++++++++++++++++++++++++++++++++++
>>  5 files changed, 604 insertions(+), 574 deletions(-)
> 
> I'm not so fond of blowing up object.c with stuff that was originally in
> its own file. Had you considered a new qom/object-properties.c?

I hadn't, but it can be done.  I can do it next week, or review the
result, as you prefer.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]